[Mod] Farming Redo [1.49] [farming]

adikalon
Member
Posts: 35
Joined: Fri Jul 26, 2024 07:37

Re: [Mod] Farming Redo [1.49] [farming]

by adikalon » Post

adikalon wrote:
Fri Jul 26, 2024 23:24
@TenPlus1, it looks like all ore and many other elements have eatable groups
The problem is because of ethereal, it adds eatable ores, etc.
And by the way ethereal:fern_tubers left with a heart
cdb_a4464263c7b3

User avatar
TenPlus1
Member
Posts: 3992
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Re: [Mod] Farming Redo [1.49] [farming]

by TenPlus1 » Post

@adikalon - How do you mean eatable ores ? the {eatable} group is only added to food items. Tubers fixed!

adikalon
Member
Posts: 35
Joined: Fri Jul 26, 2024 07:37

Re: [Mod] Farming Redo [1.49] [farming]

by adikalon » Post

@TenPlus1, i don't know how to add a picture. Here is the link:
https://i.postimg.cc/g2Wb2rzP/2024-07-27-16-45-24.png

The game is launched with only two mods: ethereal and tt_base (with my fix). As you can see, copper gives 4 saturation points (all ores give 4 saturation points). Without ethereal everything works fine, so the problem is there.

Perhaps I made a mistake when correcting tt_base, but I really doubt it. I know this is not your mod, but you can see here how I made the fix: https://codeberg.org/wuzzy/minetest_tt_base/pulls/4
cdb_a4464263c7b3

User avatar
TenPlus1
Member
Posts: 3992
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Re: [Mod] Farming Redo [1.49] [farming]

by TenPlus1 » Post

@adikalon - I can assure you that Ethereal mod does not touch any of the default ores in-game and only adds {eatable} group to food items, the issue has to be elsewhere.

Note: I tested ore groups using tt mod and nothing changes before and after Ethereal is run, it's only when your own mod is introduced that ores have the {eatable} entry added.

adikalon
Member
Posts: 35
Joined: Fri Jul 26, 2024 07:37

Re: [Mod] Farming Redo [1.49] [farming]

by adikalon » Post

@TenPlus1, I'm wandering through your code and really can't find anything like this. However, if I comment out this line, the problem goes away. Weird...
https://i.postimg.cc/26pyxhhX/2024-07-27-19-47-39.png
cdb_a4464263c7b3

User avatar
TenPlus1
Member
Posts: 3992
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Re: [Mod] Farming Redo [1.49] [farming]

by TenPlus1 » Post

@adikalon - I've hardened the {eatable} function a tad, check if it works now.

adikalon
Member
Posts: 35
Joined: Fri Jul 26, 2024 07:37

Re: [Mod] Farming Redo [1.49] [farming]

by adikalon » Post

@TenPlus1, everything seems to be working as it should now. Thank you
cdb_a4464263c7b3

User avatar
TenPlus1
Member
Posts: 3992
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Update:

by TenPlus1 » Post

- Detects and properly uses mineclone or default sounds.
- Lucky Block drops have better MineClone support.

User avatar
TenPlus1
Member
Posts: 3992
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Update:

by TenPlus1 » Post

- Hoes can now be used as weapons, dealing damage to players and entities.

User avatar
TenPlus1
Member
Posts: 3992
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Update:

by TenPlus1 » Post

- Added new 16px textures so items don't look so mis-matched.

User avatar
TenPlus1
Member
Posts: 3992
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Update:

by TenPlus1 » Post

- Added Vegan Butter and Jerusalem Artichokes.

adikalon
Member
Posts: 35
Joined: Fri Jul 26, 2024 07:37

Re: [Mod] Farming Redo [1.49] [farming]

by adikalon » Post

@TenPlus1 - Thanks for supporting the mod. I use the fbt_witt mod, do you plan to add support for it? At the moment, it does not display information about the intermediate stages of plant growth.

This is what it looks like:
https://i.postimg.cc/JhFD3mSF/screensho ... 195231.png

And this is what it should look like:
https://i.postimg.cc/C1fZmXgx/screensho ... 195313.png

The problem is the lack of the description property in the registered nodes, in theory this is easy to fix and nothing should break
cdb_a4464263c7b3

User avatar
TenPlus1
Member
Posts: 3992
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Re: [Mod] Farming Redo [1.49] [farming]

by TenPlus1 » Post

@adikalon - So the issue is that crop stages don't have descriptions set ?

Check today's update, I've added descriptions to any crops registered using the API, so oats and rye should show proper descriptions on hover, the rest I will need to do manually.

adikalon
Member
Posts: 35
Joined: Fri Jul 26, 2024 07:37

Re: [Mod] Farming Redo [1.49] [farming]

by adikalon » Post

@TenPlus1 - No. It doesn't work. It is necessary to add a description to each each crop in the crops folder
cdb_a4464263c7b3

User avatar
TenPlus1
Member
Posts: 3992
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Re: [Mod] Farming Redo [1.49] [farming]

by TenPlus1 » Post

@adikalon - That was simply a test update to see if it worked on Rye and Oats, I've finished adding descriptions to all crops now and updated mod.

adikalon
Member
Posts: 35
Joined: Fri Jul 26, 2024 07:37

Re: [Mod] Farming Redo [1.49] [farming]

by adikalon » Post

@TenPlus1 - It works, thank you very much
cdb_a4464263c7b3

User avatar
xianjiro
Member
Posts: 51
Joined: Thu Aug 31, 2017 05:49
Location: West Coast North America
Contact:

Re: [Mod] Farming Redo [1.49] [farming]

by xianjiro » Post

I tried searching but couldn't scare up anything but I've noticed some sort of conflict between this mod and x_farming (please forgive if this is already known). While I haven't noticed any issues with Farming Redo, if it's loaded then I can't get any seeds from x_farming to sprout. I figured I was doing something wrong -- mostly in where I planted x_farming crops but something made me wonder ... so I turned off Farming Redo (ugh, all those Unknown Nodes!) and x_farming seeds germinate just fine. I've no idea where or why the conflict (nor if another mod might somehow impact the issue in some way), but maybe my work-around suggests something to someone more knowledgeable about the game and mods' programming. BTW, I upgraded from 5.5.0 to 5.8.0 some months back and play Minetest Game without hosting a server.

User avatar
TenPlus1
Member
Posts: 3992
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Re: [Mod] Farming Redo [1.49] [farming]

by TenPlus1 » Post

@xianjiro - Running mods that do similar things like Farming Redo and x_farming may cause compatibility issues, I will however look into this issue and see what may be causing it.

Fixed: It turns out x_farming needs the {grassland} group set for soil types, and once that was added both mods started playing nicely again :) so please update your Farming Redo.

User avatar
xianjiro
Member
Posts: 51
Joined: Thu Aug 31, 2017 05:49
Location: West Coast North America
Contact:

Re: [Mod] Farming Redo [1.49] [farming]

by xianjiro » Post

@TenPlus1 - thanks! That did the trick.

And while part of my thinking before turning off Farming Redo was for the reason you mentioned, I confess to not understanding how mods work and conflict with each other even when looking at the lua code. No idea exactly when I installed the two mods though it was at substantially different times. Anyway, thanks for the quick fix.

User avatar
TenPlus1
Member
Posts: 3992
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Update:

by TenPlus1 » Post

- Tweaked poisson functions.
- Added {grassland} group to soil.
- New 16px textures for certain food items.
- Make pineapple textures more bushlike in size.
- Tidied code.

User avatar
TenPlus1
Member
Posts: 3992
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Update:

by TenPlus1 » Post

- Crop decoration takes into account Ethereal grass blocks.

adikalon
Member
Posts: 35
Joined: Fri Jul 26, 2024 07:37

Re: [Mod] Farming Redo [1.49] [farming]

by adikalon » Post

@TenPlus1 - How about changing default:stone to group:stone? This would add compatibility for underground challenge (underch) mod and possibly other stone mods
cdb_a4464263c7b3

User avatar
TenPlus1
Member
Posts: 3992
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Update:

by TenPlus1 » Post

- Mortar and Juicer recipes now use group:stone (thx adikalon)

User avatar
TenPlus1
Member
Posts: 3992
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Update:

by TenPlus1 » Post

- Add {drink} group to soups and mint tea.

User avatar
TenPlus1
Member
Posts: 3992
Joined: Mon Jul 29, 2013 13:38
In-game: TenPlus1
Contact:

Update:

by TenPlus1 » Post

- Changed Asparagus,Spinach,Ginger offset to 0, the previous value stopped spawning.

Post Reply